Fix library showing every Steam game as installed#612
Merged
Conversation
When app metadata was unavailable (service restarting or catalog not loaded yet), getAppDirPath resolved every app to the shared install root; a stray download-complete marker there made install recovery fabricate installed records for the whole library until a force close. Return an empty path when no folder name can be resolved and skip install recovery on blank paths.
Install-state metadata reads went through the live service instance and returned nothing while the service was down (e.g. killed during a large component install), so the library scan saw zero installed games and the cached result stuck until an app restart. Fall back to the database singleton for app metadata and install records.
Pulling down re-runs the shortcut and install-state scans and shows a refresh indicator, including on the empty state so a stale empty library can be recovered without restarting the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When app metadata was unavailable (service restarting or catalog not loaded yet), getAppDirPath resolved every app to the shared install root; a stray download-complete marker there made install recovery fabricate installed records for the whole library until a force close. Return an empty path when no folder name can be resolved and skip install recovery on blank paths.